Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Client should pass client_options.api_key to auth library #321

Merged
merged 9 commits into from
Feb 13, 2025
Merged

Feat: Client should pass client_options.api_key to auth library #321

merged 9 commits into from
Feb 13, 2025

Conversation

andrewsg
Copy link
Contributor

Fixes #319 🦕

@andrewsg andrewsg requested a review from parthea February 11, 2025 01:04
@andrewsg andrewsg requested a review from a team as a code owner February 11, 2025 01:04
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Feb 11, 2025
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Feb 11, 2025
parthea
parthea reviewed Feb 13, 2025
View reviewed changes
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but holding off on formal approval until comments are addressed

@andrewsg
Copy link
Contributor Author

Thanks! Applied suggestions, PTAL.

@parthea parthea merged commit dfac15b into main Feb 13, 2025
17 checks passed
@parthea parthea deleted the api_key branch February 13, 2025 19:39
@release-please release-please bot mentioned this pull request Feb 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthea parthea parthea approved these changes

Assignees

@parthea parthea

Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If api_key is set in client options, pass it through to auth
2 participants
@andrewsg @parthea